Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ts] Remove override modifier #13381

Merged
merged 1 commit into from May 27, 2021
Merged

[ts] Remove override modifier #13381

merged 1 commit into from May 27, 2021

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented May 27, 2021 •
edited

Q                       A
Fixed Issues? Fixes #13380
Patch: Bug Fix? Y
Tests Added + Pass? Yes
Documentation PR Link
License MIT

@sosukesuzuki sosukesuzuki added area: typescript PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels May 27, 2021
@fedeci fedeci added the PR: Spec Compliance 👓 A type of pull request used for our changelog categories label May 27, 2021
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46499/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 23860c8:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

nicolo-ribaudo
nicolo-ribaudo approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@existentialism existentialism changed the title [ts] Remove override modifer [ts] Remove override modifier May 27, 2021
@existentialism existentialism merged commit c6bebfe into babel:main May 27, 2021
@sosukesuzuki sosukesuzuki deleted the remove-override branch May 27, 2021 15:54
@jtbandes
Copy link

When will this be available in a patch release? Seems like it's not possible to run transpiled TS code with overrides until this is included :)

@jtbandes jtbandes mentioned this pull request May 27, 2021
Merged
3 tasks
@nicolo-ribaudo
Copy link
Member

We'll probably release a patch today.

@nicolo-ribaudo nicolo-ribaudo removed the PR: Spec Compliance 👓 A type of pull request used for our changelog categories label May 28, 2021
@nicolo-ribaudo
Copy link
Member

Released in v7.14.4 of the TS plugin

@lgarron
Copy link

lgarron commented May 28, 2021

Released in v7.14.4 of the TS plugin

Hmm, there's a v7.14.4 release of @babel/preset-env.

But picking up that version doesn't seem to be enough to prevent errors in my project. Should there be an accompanying @babel/preset-typescript release?

@nicolo-ribaudo
Copy link
Member

No, the fix is in @babel/plugin-transform-typescript which is a dependency of @babel/preset-typescript. You can try running npm --depth 9999 update @babel/plugin-transform-typescript to update it.

@sync-by-unito sync-by-unito bot mentioned this pull request May 31, 2021
Closed
This was referenced Jun 10, 2021
Closed
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@fedeci fedeci fedeci approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: "override" modifier of TypeScript 4.3.0 is not removed when transforming to JavaScript
7 participants
@sosukesuzuki @babel-bot @jtbandes @nicolo-ribaudo @lgarron @fedeci @existentialism